ci: add linux-packages dispatch to release workflow#40
Conversation
Trigger APT/RPM repository update in open-cli-collective/linux-packages when sfdc releases are published. Closes #39
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 542f963
Approved with 1 non-blocking suggestion below. Address at your discretion.
Summary
| Reviewer | Findings |
|---|---|
| harness-engineering:architecture-reviewer | 1 |
harness-engineering:architecture-reviewer (1 findings)
💡 Suggestion - .github/workflows/release.yml:209
If
LINUX_PACKAGES_DISPATCH_TOKENis not configured, the dispatch will fail silently (masked bycontinue-on-error: true). Consider adding a brief comment or guard step so misconfiguration is surfaced, or at minimum document the required secret and its scopes (e.g.,repoorworkflow) somewhere discoverable (README or a comment in this file).
1 info-level observations excluded. Run with --verbose to include.
Completed in 2m 21s | $0.37
| Field | Value |
|---|---|
| Reviewers | hybrid-synthesis, harness-engineering:knowledge-reviewer, harness-engineering:enforcement-reviewer, harness-engineering:architecture-reviewer, harness-engineering:legibility-reviewer |
| Reviewed by | pr-review-daemon · monit-pr-reviewer |
| Duration | 2m 21s (Reviewers: 45s · Synthesis: 35s) |
| Cost | $0.37 |
| Tokens | 142.1k in / 7.8k out |
| Turns | 10 |
| - name: Trigger linux-packages repo update | ||
| uses: peter-evans/repository-dispatch@v3 | ||
| with: | ||
| token: ${{ secrets.LINUX_PACKAGES_DISPATCH_TOKEN }} |
There was a problem hiding this comment.
🔵 Low (harness-engineering:architecture-reviewer): If LINUX_PACKAGES_DISPATCH_TOKEN is not configured, the dispatch will fail silently (masked by continue-on-error: true). Consider adding a brief comment or guard step so misconfiguration is surfaced, or at minimum document the required secret and its scopes (e.g., repo or workflow) somewhere discoverable (README or a comment in this file).
2 participants
Summary
linux-packagesdispatch job torelease.ymlopen-cli-collective/linux-packagesreceive-package.ymlon each releasecontinue-on-error: trueso dispatch failures do not block the releaseCloses #39
Test plan