Skip to content

Further debugging of the event detector#152

Open
hellais wants to merge 8 commits intomainfrom
detector-debug
Open

Further debugging of the event detector#152
hellais wants to merge 8 commits intomainfrom
detector-debug

Conversation

@hellais
Copy link
Member

@hellais hellais commented Feb 25, 2026

  • Add support for warming up the event detector
  • Remove the variance label
  • Fix alert query parameter passing

* Add support for warming up the event detector
* Remove the variance label
* Fix alert query parameter passing
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.86%. Comparing base (6fd1e35) to head (46b8272).

❌ Your project check has failed because the head coverage (77.86%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (6fd1e35) and HEAD (46b8272). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (6fd1e35) HEAD (46b8272)
oonidata 10 5
oonipipeline 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   83.92%   77.86%   -6.07%     
==========================================
  Files          85       33      -52     
  Lines        5220     1938    -3282     
==========================================
- Hits         4381     1509    -2872     
+ Misses        839      429     -410     
Flag Coverage Δ
oonidata 77.86% <ø> (ø)
oonipipeline ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hellais
Copy link
Member Author

hellais commented Feb 25, 2026

This will require running the following migration queries on clickhouse:

ALTER TABLE event_detector_cusums
    DROP COLUMN dns_isp_blocked_obs_w_sum,
    DROP COLUMN dns_isp_blocked_w_sum,
    DROP COLUMN dns_other_blocked_obs_w_sum,
    DROP COLUMN dns_other_blocked_w_sum,
    DROP COLUMN tcp_blocked_obs_w_sum,
    DROP COLUMN tcp_blocked_w_sum,
    DROP COLUMN tls_blocked_obs_w_sum,
    DROP COLUMN tls_blocked_w_sum;

ALTER TABLE event_detector_cusums
    ADD COLUMN dns_isp_blocked_current_state String DEFAULT 'ok',
    ADD COLUMN dns_other_blocked_current_state String DEFAULT 'ok',
    ADD COLUMN tcp_blocked_current_state String DEFAULT 'ok',
    ADD COLUMN tls_blocked_current_state String DEFAULT 'ok';

ALTER TABLE event_detector_changepoints
    DROP COLUMN IF EXISTS dns_isp_blocked_obs_w_sum,
    DROP COLUMN IF EXISTS dns_isp_blocked_w_sum,
    DROP COLUMN IF EXISTS dns_other_blocked_obs_w_sum,
    DROP COLUMN IF EXISTS dns_other_blocked_w_sum,
    DROP COLUMN IF EXISTS tcp_blocked_obs_w_sum,
    DROP COLUMN IF EXISTS tcp_blocked_w_sum,
    DROP COLUMN IF EXISTS tls_blocked_obs_w_sum,
    DROP COLUMN IF EXISTS tls_blocked_w_sum,
    DROP COLUMN IF EXISTS current_mean;

ALTER TABLE event_detector_changepoints
    ADD COLUMN IF NOT EXISTS current_state String DEFAULT 'ok';

workaround for `Environment default is incompatible: module 'virtualenv.discovery.builtin' has no attribute 'propose_interpreters'`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant