Feature/bt 1496 identity setup single transaction#142
Merged
mohamadhammoud merged 12 commits intodevelopfrom Apr 8, 2026
Merged
Feature/bt 1496 identity setup single transaction#142mohamadhammoud merged 12 commits intodevelopfrom
mohamadhammoud merged 12 commits intodevelopfrom
Conversation
pgonday
requested changes
Feb 19, 2026
pgonday
requested changes
Feb 23, 2026
Collaborator
pgonday
left a comment
pgonday
left a comment
There was a problem hiding this comment.
removeClaimcan be called byCLAIM_ADDERwith theexecutefunction- no check for valid identityType
pgonday
requested changes
Feb 23, 2026
| } | ||
|
|
||
| // bootstraps an identity: adds claim adder keys, transfers ownership, removes factory key | ||
| function _setupIdentityKeys( |
Contributor
There was a problem hiding this comment.
to avoid code duplicates i would use this internal function in both identity deployment functions (1 or many management keys). instead of address _owner just put an array of management keys. for the simple deploy function that array only contains the owner address.
| import { ECDSA } from "@openzeppelin/contracts/utils/cryptography/ECDSA.sol"; | ||
| import { UUPSUpgradeable } from "@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol"; | ||
|
|
||
| contract ClaimIssuer is IClaimIssuer, Identity, UUPSUpgradeable { |
| import { UUPSUpgradeable } from "@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol"; | ||
|
|
||
| contract ClaimIssuer is IClaimIssuer, Identity, UUPSUpgradeable { | ||
| mapping(bytes => bool) public revokedClaims; |
| function initialize( | ||
| address initialManagementKey | ||
| address initialManagementKey, | ||
| uint256 |
Contributor
There was a problem hiding this comment.
linter is not happy here, need to fix it
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
mohamadhammoud
force-pushed
the
feature/BT-1496-identity-setup-single-transaction
branch
from
24a5494 to
806a427
Compare
mohamadhammoud
force-pushed
the
feature/BT-1496-identity-setup-single-transaction
branch
from
806a427 to
5658e3d
Compare
mohamadhammoud
force-pushed
the
feature/BT-1496-identity-setup-single-transaction
branch
from
5658e3d to
da5eb09
Compare
Contributor
|
please add a function on the gateway that allows the gateway owner to add a token factory address on the IdFactory. The function already exists on the factory but it is not exposed on the gateway |
pgonday
requested changes
Mar 19, 2026
| override | ||
| initializer | ||
| { | ||
| __ClaimIssuer_init(initialManagementKey); |
Collaborator
There was a problem hiding this comment.
Can't you just do super.initialize(initialManagementKey, IdentityTypes.CLAIM_ISSUER);
and remove __ClaimIssuer_init
Collaborator
Author
There was a problem hiding this comment.
c16f928
We can't use super.initialize() directly because both functions are external, I removed __ClaimIssuer_init entirely and inlined its logic directly into initialize
pgonday
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.