fix: dialog race condition fix & testing#53
Open
chanderlud wants to merge 5 commits intoonce-ui-system:mainfrom
Open
fix: dialog race condition fix & testing#53chanderlud wants to merge 5 commits intoonce-ui-system:mainfrom
chanderlud wants to merge 5 commits intoonce-ui-system:mainfrom
Conversation
Contributor
chanderlud
commented
Apr 1, 2026
chanderlud
commented
- if the Dialog component is opened and closed rapidly, it will leave the UI in a stuck/disabled state due to a race condition in the cleanup
- i resolved this issue by improving the Dialog and ScrollLock components
- i added testing to the project & implemented tests for the Dialog and ScrollLock to verify the behavior across a large range of conditions
|
@chanderlud is attempting to deploy a commit to the Dopler Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.