Skip to content

Comments

feat: prevent duplicate validators in codegen#510

Open
perher wants to merge 1 commit intoomissis:mainfrom
perher:feature/prevent-duplicate-validators
Open

feat: prevent duplicate validators in codegen#510
perher wants to merge 1 commit intoomissis:mainfrom
perher:feature/prevent-duplicate-validators

Conversation

@perher
Copy link
Contributor

@perher perher commented Jan 25, 2026

This PR fixes a bug where duplicate validator methods could be created for types that were using subschemas with anyOf/allOf.

Proposed solution in PR is to perform a strict duplicate check in codegen and not emit methods if already emitted.

@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

❌ Patch coverage is 21.31148% with 48 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@37d54f2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tests/data/core/allOf/allOfNestedRefs.go 0.00% 48 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage        ?   40.88%           
=======================================
  Files           ?       67           
  Lines           ?     5702           
  Branches        ?        0           
=======================================
  Hits            ?     2331           
  Misses          ?     3095           
  Partials        ?      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants