Update devicePixelRatio in onMetricsChanged#17
Open
jimgerth wants to merge 1 commit intoominibyte:masterfrom
Open
Update devicePixelRatio in onMetricsChanged#17jimgerth wants to merge 1 commit intoominibyte:masterfrom
jimgerth wants to merge 1 commit intoominibyte:masterfrom
Conversation
Previously the devicePixelRatio was only set once at initialization, when it possibly was not available yet. This could lead to a wrong device type detection (e.g. a OnePlus Nord was reliably detected to be a tablet when running a Flutter app in release mode). Since the devicePixelRatio can change with an onMetricsChanged call, update the static devicePixelRatio variable in that callback to fix the device type detection. Signed-off-by: Jim Gerth <jgerth@jusst.de>
Author
|
This could possibly fix #16, someone with that device would have to check, though. |
Author
|
@ominibyte It would be awesome, if you could take a quick look at this, as it fixes some devices being wrongly detected, especially in release mode. Maybe you even have time to do a release to pub.dev with the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the devicePixelRatio was only set once at initialization, when it possibly was not available yet. This could lead to a wrong device type detection (e.g. a OnePlus Nord was reliably detected to be a tablet when running a Flutter app in release mode). Since the devicePixelRatio can change with an onMetricsChanged call, update the static devicePixelRatio variable in that callback to fix the device type detection.