-
Notifications
You must be signed in to change notification settings - Fork 104
Api wells2 #5069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Api wells2 #5069
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7c302c1
PlateView.add_data() uses api_query.get_wellsample_indices()
will-moore a69833a
Blitz PlateAcquisition getQueryString() to filter by plate
will-moore a0e0063
Support /plates/:id/plateacquisitions/
will-moore 6b2d29f
Blitz Well.getQueryString() supports filter by 'plateacquisition'
will-moore 7c70b45
/plateacquisition/:id/wells/ filters Wells by plate_acquisition
will-moore 048adc0
Add 'url:plateacquisitions' to plate json
will-moore edbb992
Support /plateacquistions/:id/ includes min/max wellsampleIndex
will-moore 1bfe9b8
Add url 'plateacquisitions/:id/index/:idx/wells' to plate_acq json
will-moore 9253577
Blitz Well getQueryString() supports filter by 'wellsample_index'
will-moore 8e3e5d6
api WellsView handles 'index' to filter by wellsample_index
will-moore 83f675e
Merge remote-tracking branch 'origin/develop' into api_wells2
will-moore 84d177c
Add support for /plates/id/index/0/wells/
will-moore be36738
Add 'urls:wellsampleindex_wells' to PlateAcquisition and Plate views
will-moore 58b6c30
Add tests for listing 'index' urls in plate/plate_acquisition
will-moore fc3d278
Remove duplicate imports
will-moore c03093a
Use 'url:' prefix for url:wellsampleindex_wells.
will-moore 424ef1b
Fix merge conflict
will-moore f17506b
Tidy imports in test_api_wells.py
will-moore 3a71a64
Tiny fix in docstring
will-moore 1f6229e
Blitz helper add_plate_filter() used in getQueryString()
will-moore 7918868
Merge remote-tracking branch 'origin/develop' into api_wells2
will-moore 50efc29
flake8 fix
will-moore 1320d39
Fix test_spw_urls
will-moore 2b2a9b9
Use 'wellsampleindex' in urls
will-moore 2d94baf
Update 'index' -> 'wellsampleindex' in url names
will-moore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to allow to filter by plate id and plateacquisition id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's a case for that, since plateacquisition ID would also define plate ID.