Skip to content

Enable omero-certificates#48

Merged
joshmoore merged 1 commit into
ome:masterfrom
manics:certificates
Dec 4, 2020
Merged

Enable omero-certificates#48
joshmoore merged 1 commit into
ome:masterfrom
manics:certificates

Conversation

@manics
Copy link
Copy Markdown
Member

@manics manics commented Dec 3, 2020

Enables omero-certificates (ome/ansible-role-omero-server#50)
See https://forum.image.sc/t/trouble-connecting-to-omero-server-with-python/46097/10 , I can't see any harm in enabling it by default.

Requires this bug fix to the config system: #47

@manics manics marked this pull request as draft December 3, 2020 18:27
@joshmoore joshmoore marked this pull request as ready for review December 4, 2020 12:11
@joshmoore
Copy link
Copy Markdown
Member

  • Code looks good.
  • Rebased & force pushed.
  • Waiting on build.

@joshmoore
Copy link
Copy Markdown
Member

Green again! Thanks, @manics. Merging. Similar question as to gh-47: anything else before a release?

@joshmoore joshmoore merged commit 80c2270 into ome:master Dec 4, 2020
@manics manics deleted the certificates branch December 7, 2020 09:20
@manics
Copy link
Copy Markdown
Member Author

manics commented Dec 7, 2020

Might as well include #20 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants