Renderfacility#93
Merged
dominikl merged 12 commits intoome:masterfrom Mar 25, 2026
Merged
Conversation
jburel
reviewed
Sep 20, 2024
| public boolean isRGB(SecurityContext ctx, long imageId) throws DSOutOfServiceException, DSAccessException { | ||
| try { | ||
| ImageData img = gateway.getFacility(LoadFacility.class).getImage(ctx, imageId); | ||
| int nChannles = img.getDefaultPixels().getSizeC(); |
jburel
reviewed
Nov 19, 2024
| } | ||
|
|
||
| /** | ||
| * Checks if an image is an RGB(A) image. |
Member
There was a problem hiding this comment.
Maybe indicate in the description that the RenderingEngine is not closed
dominikl
force-pushed
the
renderfacility
branch
from
7883920 to
2becc06
Compare
Member
Author
|
Ok to merge @jburel ? Not urgently required, just add rendering method to gateway, might be useful. |
jburel
reviewed
Jan 27, 2026
| /* | ||
| *------------------------------------------------------------------------------ | ||
| * Copyright (C) 2015-2017 University of Dundee. All rights reserved. | ||
| * Copyright (C) 2015-2024 University of Dundee. All rights reserved. |
|
|
||
| /** | ||
| * Tries to determine if an image is an RGB(A) image. | ||
| * (Note: This does not necessarily give the same results as Bioformats isRGB()!) |
Member
There was a problem hiding this comment.
The difference should probably be clarified
Co-authored-by: jean-marie burel <j.burel@dundee.ac.uk>
Co-authored-by: jean-marie burel <j.burel@dundee.ac.uk>
Co-authored-by: jean-marie burel <j.burel@dundee.ac.uk>
Co-authored-by: jean-marie burel <j.burel@dundee.ac.uk>
Co-authored-by: jean-marie burel <j.burel@dundee.ac.uk>
Member
Author
|
Merging. Probably nobody will use the RenderFacility, but it doesn't do any harm either :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Renderfacility, with some basic rendering methods. Inspired by #92 .