[FIX] code, expressions: translate t-attf-#1807
Open
kebeclibre wants to merge 1 commit intomasterfrom
Open
Conversation
kebeclibre
force-pushed
the
master-translate-tattf-lpe
branch
from
2290e01 to
dccc71d
Compare
kebeclibre
added a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 16, 2026
Before this commit, t-attf attributes were not translated in owl templates In odoo, they are since odoo#201511 (in qweb python that is). This commit allows for collecting those expression in the translations. As for the python, expressions are slightly modified. `t-attf-title="Some {{ this.object }} View {{ this.viewId }}"` is transformed into `"Some {{0}} View {{1}}"` That way, expressions cannot be mistakenly translated in the string received from the translation function. owl-pr: odoo/owl#1807 task-6033548
kebeclibre
force-pushed
the
master-translate-tattf-lpe
branch
from
dccc71d to
a361601
Compare
kebeclibre
force-pushed
the
master-translate-tattf-lpe
branch
2 times, most recently
from
0e02a60 to
d41a5b5
Compare
Before this commit, t-attf attributes were not translated. In odoo, they are since odoo/odoo#201511 (in qweb python that is). This commit implements the translations of t-attf attributes as long as their static counterpart is also translatable. ie: "title" and "t-attf-title" but NOT "data-random" and "t-attf-data-random" The spec is that expressions composing the formatted string are not visible to the translator, and are just indexed and reinjected. That is: `t-attf-title="Some {{ this.object }} View {{ this.viewId }}"` is transformed into `"Some {{0}} View {{1}}"` That way, expressions cannot be mistakenly translated in the string received from the translation function. task-6033548
kebeclibre
force-pushed
the
master-translate-tattf-lpe
branch
from
d41a5b5 to
584abb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, t-attf attributes were not translated. In odoo, they are since odoo/odoo#201511 (in qweb python that is).
This commit implements the translations of t-attf attributes as long as their static counterpart is also translatable.
ie: "title" and "t-attf-title"
but NOT "data-random" and "t-attf-data-random"
The spec is that expressions composing the formatted string are not visible to the translator, and are just indexed and reinjected.
That is:
t-attf-title="Some {{ this.object }} View {{ this.viewId }}"is transformed into"Some {{1}} View {{2}}"That way, expressions cannot be mistakenly translated in the string received from the translation function.
task-6033548