Claude/fix pwa landscape android bx nrr#670
Merged
Conversation
Change manifest orientation from 'portrait' to 'any' so Android Chrome allows the installed PWA to rotate to landscape. iOS Safari ignores this field, so no impact there. Note: existing installs need to be reinstalled to pick up the change. https://claude.ai/code/session_01CX1JWcjRBXSgg8sVW58pQP
The copyFavicons and generateManifest gulp tasks ran in parallel, causing the static manifest.json (which lacks orientation) to overwrite the generated one. Now copyFavicons excludes manifest files, and generateManifest runs after copyFavicons to guarantee the generated manifest with orientation: 'any' is what ships. https://claude.ai/code/session_01CX1JWcjRBXSgg8sVW58pQP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.