Skip to content

fix: privacy admin section UI improvements #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzueger merged 2 commits into from
Mar 22, 2026
Merged

fix: privacy admin section UI improvements #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bb919d
fix: use available icon for privacy admin nav item
rzueger Mar 22, 2026
8f768c2
fix: improve visual grouping in privacy settings form
rzueger Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/AdminPage/AdminNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ const AdminNavigation = ({ activeTab, hiddenTabs, onTabChange }) => {
{ key: 'kiosk-access', label: t('admin.kioskAccess'), icon: 'person_add' },
{ key: 'guest-access', label: t('admin.guestAccess'), icon: 'person_add' },
{ key: 'import', label: t('admin.import'), icon: 'file_upload' },
{ key: 'privacy', label: t('admin.privacy'), icon: 'shield' },
{ key: 'privacy', label: t('admin.privacy'), icon: 'security' },
].filter(item => !hiddenTabs.includes(item.key));

return (
Expand Down
94 changes: 56 additions & 38 deletions src/components/PrivacySettingsForm/PrivacySettingsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,22 @@ import LabeledBox from '../LabeledBox';
import Button from '../Button';
import styled from 'styled-components';

const FieldGroup = styled.div`
margin-bottom: 1.5em;
padding-bottom: 1.5em;
border-bottom: 1px solid #eee;

&:last-of-type {
border-bottom: none;
margin-bottom: 1em;
padding-bottom: 0;
}
`;

const HelpText = styled.p`
color: #666;
font-size: 0.9em;
margin: 0.25em 0 1em 0;
margin: 0.25em 0 0 0;
`;

interface PrivacySettingsFormProps {
Expand Down Expand Up @@ -56,45 +68,51 @@ function PrivacySettingsForm(props: PrivacySettingsFormProps) {
<Form onSubmit={handleSubmit} initialValues={initialValues}>
{({ handleSubmit, dirty }) => (
<form onSubmit={handleSubmit}>
<FieldSet gutter={false}>
<Field
name="privacyPolicyUrl"
type="url"
label={t('privacy.privacyPolicyUrl')}
component={renderInputField}
/>
</FieldSet>
<HelpText>{t('privacy.privacyPolicyUrlHelp')}</HelpText>
<FieldGroup>
<FieldSet gutter={false}>
<Field
name="privacyPolicyUrl"
type="url"
label={t('privacy.privacyPolicyUrl')}
component={renderInputField}
/>
</FieldSet>
<HelpText>{t('privacy.privacyPolicyUrlHelp')}</HelpText>
</FieldGroup>

<FieldSet gutter={false}>
<Field
name="movementRetentionDays"
type="number"
label={t('privacy.movementRetentionDays')}
component={renderInputField}
parse={(value: string) => {
if (value === '') return '';
const num = parseInt(value, 10);
return isNaN(num) ? '' : num;
}}
/>
</FieldSet>
<HelpText>{t('privacy.movementRetentionDaysHelp')}</HelpText>
<FieldGroup>
<FieldSet gutter={false}>
<Field
name="movementRetentionDays"
type="number"
label={t('privacy.movementRetentionDays')}
component={renderInputField}
parse={(value: string) => {
if (value === '') return '';
const num = parseInt(value, 10);
return isNaN(num) ? '' : num;
}}
/>
</FieldSet>
<HelpText>{t('privacy.movementRetentionDaysHelp')}</HelpText>
</FieldGroup>

<FieldSet gutter={false}>
<Field
name="messageRetentionDays"
type="number"
label={t('privacy.messageRetentionDays')}
component={renderInputField}
parse={(value: string) => {
if (value === '') return '';
const num = parseInt(value, 10);
return isNaN(num) ? '' : num;
}}
/>
</FieldSet>
<HelpText>{t('privacy.messageRetentionDaysHelp')}</HelpText>
<FieldGroup>
<FieldSet gutter={false}>
<Field
name="messageRetentionDays"
type="number"
label={t('privacy.messageRetentionDays')}
component={renderInputField}
parse={(value: string) => {
if (value === '') return '';
const num = parseInt(value, 10);
return isNaN(num) ? '' : num;
}}
/>
</FieldSet>
<HelpText>{t('privacy.messageRetentionDaysHelp')}</HelpText>
</FieldGroup>

<Button
type="submit"
Expand Down
Loading