Conversation
The only module in the nix repo which uses this library at the moment is printhost, and the only host using that module is `tule`. There are some changes made to printers.py in [the corresponding commit on ocflib](ocf/ocflib@94d13fc), the most relevant being that `pysnmp` was replaced with `puresnmp`. Hopefully, as other services are migrated to nix hosts or kubernetes, they will also use this updated version of ocflib.
518e7b6 to
15173a4
Compare
Contributor
|
ocf-sync-etc was also updated in this pr, was that intended? also, there’s no way printhost is the only thing that uses ocflib right? why would we have had it as an input before |
Member
Author
|
the sync etc was not at first intentional, but it doesn't hurt. i can revert if youd like tho im not sure why ocflib was an input before. perhaps because more nix host migration was intended but hadn't yet occurred? it is still available across all nix hosts thanks to base.nix, so it can be imported in any ad-hoc python scripts run on them. but i cant think of any current examples of said scripts so.. lol but yeah, printhost is the only module so far to actually use it. none of our current nix hosts would need it for anything (but future ones prob will) |
BNH440
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only module in the nix repo which uses this library at the moment is printhost, and the only host using that module is
tule. There are some changes made to printers.py in the corresponding commit on ocflib, the most relevant being thatpysnmpwas replaced withpuresnmp. Hopefully, as other services are migrated to nix hosts or kubernetes, they will also use this updated version of ocflib (which upgraded from python 3.12 to 3.14)