Closed
Conversation
Member
|
I wonder if we should exercise updating to 5.4 AST instead? This will get us this and other features like named tuples for free. |
Member
Author
|
Totally made the update here #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for raw identifiers (OCaml 5.2 / RFC 27) to the MLX lexer, allowing keywords to be used as identifiers via the # prefix.
This unblocks polyvariant tags that collide with OCaml keywords, which is common for HTML attribute values:
The implementation mirrors the OCaml compiler's lexer: a
raw_ident_escapeis matched before the regular identifier rules, emittingLIDENTdirectly without keyword-table lookup. Applied toLABEL,OPTLABEL,LIDENT, andJSX_LIDENTrules across mlx/lexer.mll and ocamlmerlin_mlx/ocaml/preprocess/lexer_raw.mll.It also allows
<#lazy>as a component name