Conversation
* Create markdown-form.md * Update markdown-form.md * Update markdown-form.md * Update markdown-form.md * Delete markdown-form.md * Add files via upload markdown syntax * Create header-syntax.md header-syntax * Create coding-questions.md coding questions * Create multiple-question.md multiple question * Create yes-no-question.md yes or no question * Rename coding-questions.md to coding-question.md * Create likert-question.md likert question * Create open-question.md open question * Create affiliate-question.md * Update coding-question.md * Update affiliate-question.md affiliate question * Update open-question.md open question * Create random-question.md random question * Delete markdown-syntax.md
likert question with 2 values
adding distinguish sign
The user guide
configuration du compte Meta capable d'utiliser le webhook
Passer de H2 à H1 pour le titre du document
Suppression des lignes vides
SanAlexis
left a comment
SanAlexis
left a comment
There was a problem hiding this comment.
Good start !
Need some little improvements.
| - Tout à fait d'accord /Très satisfait | ||
| - D'accord / Plutôt satisfait | ||
| - Ni d'accord, ni pas d'accord / Ni satisfait, ni insatisfait | ||
| - Pas d'accord / Plutôt insatisfai |
There was a problem hiding this comment.
Résoudre les problèmes de typo (orthographe, etc.)
There was a problem hiding this comment.
dans mon IDE, j'ai pas ce soucis de fautes et je sais pas pourquoi c'est lorsque je push mon code en ligne que j'ai ce soucis de fautes là !
| import java.io.FileReader; | ||
| import java.io.IOException; | ||
|
|
||
| public class Digester { |
There was a problem hiding this comment.
There is an opportunity to use an interface like IDigester to be able to mock it during unit tests.
| line = reader.readLine(); | ||
| } | ||
| reader.close(); | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
Since you're writing a digester, you could face two common situations:
- encountering a non existing file.
- encountering a ill-formated file.
You dealt with the first situation, what about the second ?
There was a problem hiding this comment.
j'ai utilisé un catch ( FileNotFoundExcpetion ) pour traiter la seconde situation
| public static void lectureMd(String fileReader){ | ||
| try { | ||
| BufferedReader reader = new BufferedReader(new FileReader(fileReader)); | ||
| String line = reader.readLine(); |
There was a problem hiding this comment.
We should aim at consistency with the used language. English is the preferred one, but if you choose french, use it everywhere.
There was a problem hiding this comment.
nouveau nom de la méthode readMd
| HttpClient http = HttpClient.newHttpClient(); | ||
| HttpResponse<String> response = http.send(request, HttpResponse.BodyHandlers.ofString()); | ||
| System.out.println(response.body()); | ||
| } catch (URISyntaxException | IOException | InterruptedException e) { |
There was a problem hiding this comment.
What happens if the response is a failure ?
There was a problem hiding this comment.
je teste le statuscode et je renvois ce Status pour aider à comprendre l'erreur
|
|
||
| public QuestionVisitor(){ | ||
| //initialser la liste | ||
| questions = new ArrayList<>(); |
There was a problem hiding this comment.
Architecture flag there.
The QuestionVisitor class is the only one to initialise the questions list, but it can't neither modify the list nor give write access to it. Is it done on purpose ?
QuestionVisitor is unable to operate with a already-created questions list. It is done on purpose ?
There was a problem hiding this comment.
j'ai ajouté une son contructeur qui prend une liste de questions en paramètre
6 participants
Fixed unrelated histories with main branch