Skip to content

remove "web" from reddit share url#572

Closed
monika-with-a-k wants to merge 4 commits intonygardk:masterfrom
monika-with-a-k:fix/reddit-url-fix
Closed

remove "web" from reddit share url#572
monika-with-a-k wants to merge 4 commits intonygardk:masterfrom
monika-with-a-k:fix/reddit-url-fix

Conversation

@monika-with-a-k
Copy link
Copy Markdown

@monika-with-a-k monika-with-a-k commented Mar 28, 2025

Remove "web" element from path for RedditShareButton

Current issue:

Fix:

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 28, 2025

🦋 Changeset detected

Latest commit: 99146ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-share Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@monika-with-a-k monika-with-a-k marked this pull request as ready for review March 28, 2025 21:18
Copy link
Copy Markdown
Owner

@nygardk nygardk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for the contribution.

Not the that /web was included in the path recently in this PR.

Unfortunately, I don't have the time to investigate what is the correct url after all. It might depend on the case. Nevertheless, it would be good that we don't end up going back-and-forth with the url in different releases.

Any chance you could test the case "Verified that the link is now correctly populated in Reddit share previews (#547 )" and think of a solution that would in all cases?

@caseyszilagyi
Copy link
Copy Markdown

Any plans to merge this? The current share button implementation is completely broken for me

@axis80
Copy link
Copy Markdown

axis80 commented Oct 25, 2025

Just a friendly note to urge you to please merge this PR :-)

@mattmillsxyz
Copy link
Copy Markdown

@nygardk any chance we can get this merged? I have confirmed that https://www.reddit.com/submit is the correct url for sharing links.

https://www.reddit.com/web/submit is no longer a valid working url.

@BauZee
Copy link
Copy Markdown

BauZee commented Dec 27, 2025

@nygardk I would also like to remind you to merge that, please! :)

nygardk added a commit that referenced this pull request Mar 8, 2026
PR #572 and issue reports like #571 showed that Reddit's /web/submit share URL now fails with a page-not-found flow. Switch the button back to /submit and add regression coverage for the public component.
@github-actions github-actions Bot mentioned this pull request Mar 9, 2026
@nygardk
Copy link
Copy Markdown
Owner

nygardk commented Mar 9, 2026

Addressed in v5.3.

@nygardk nygardk closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants