Add "Fiber Connected Hub" and Map Display Override Options#794
Open
Andrew-Dickinson wants to merge 7 commits intomainfrom
Open
Add "Fiber Connected Hub" and Map Display Override Options#794Andrew-Dickinson wants to merge 7 commits intomainfrom
Andrew-Dickinson wants to merge 7 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
+ Coverage 94.88% 94.89% +0.01%
==========================================
Files 89 89
Lines 3809 3823 +14
==========================================
+ Hits 3614 3628 +14
Misses 195 195 ☔ View full report in Codecov by Sentry. |
# Conflicts: # src/meshapi/views/map.py
WillNilges
reviewed
Jan 16, 2025
Collaborator
WillNilges
left a comment
WillNilges
left a comment
There was a problem hiding this comment.
Is there a slack thread about this?
Collaborator
There was a problem hiding this comment.
Can you squash these migrations?
Comment on lines
88
to
+93
| if install.node.type != Node.NodeType.STANDARD and self._is_node_dot(install): | ||
| synthetic_notes.append(install.node.type) | ||
| if install.node.type == Node.NodeType.FIBER_HUB: | ||
| # Draw fiber-connected hubs with the big blue "supernode" dot | ||
| synthetic_notes.append(Node.NodeType.SUPERNODE) | ||
| else: | ||
| synthetic_notes.append(install.node.type) |
Collaborator
There was a problem hiding this comment.
Is this because... the map doesn't support FIBER_HUB?
|
|
||
| def convert_status_to_spreadsheet_status(self, link: Link) -> str: | ||
| if link.map_display_override: | ||
| map_override_to_spreadsheet_status: Dict[str, str] = { |
Collaborator
There was a problem hiding this comment.
📓 Note: What happens if we update the MapDisplayOverride and forget to update this? Is there a test that evokes that?
Member
Author
|
Should we do this for nodes too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new hub type "Fiber Connected Hub" which renders on the map as a big blue "supernode" dot
Also adds the ability to override the display of links:
Includes changes from #793