Skip to content

Add ARIA tab semantics to BatchOperationsPanel #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alceops wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ARIA tab semantics to BatchOperationsPanel #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions web/src/components/batch-operations/BatchOperationsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ interface BatchOperationsPanelProps {

export function BatchOperationsPanel({ onExecute, onUndo, className }: BatchOperationsPanelProps) {
const [state, setState] = useState<BatchOperationState>({
type: null,
type: 'batch_edit',
isRunning: false,
progress: 0,
preview: null,
Expand Down Expand Up @@ -179,7 +179,7 @@ export function BatchOperationsPanel({ onExecute, onUndo, className }: BatchOper

const handleClear = useCallback(() => {
setState({
type: null,
type: 'batch_edit',
isRunning: false,
progress: 0,
preview: null,
Expand Down Expand Up @@ -408,14 +408,30 @@ export function BatchOperationsPanel({ onExecute, onUndo, className }: BatchOper
<h2 className="mb-4 text-lg font-semibold">Batch Operations</h2>

{/* Tabs */}
<div className="mb-4 flex gap-2 border-b border-neutral-200 pb-2 dark:border-neutral-700">
<div
role="tablist"
aria-label="Batch operation modes"
className="mb-4 flex gap-2 border-b border-neutral-200 pb-2 dark:border-neutral-700"
>
<button
id="batch-edit-tab"
type="button"
role="tab"
aria-selected={state.type === 'batch_edit'}
aria-controls="batch-edit-panel"
tabIndex={state.type === 'batch_edit' ? 0 : -1}
onClick={() => setState((prev) => ({ ...prev, type: 'batch_edit' }))}
className={`px-3 py-1 text-sm ${state.type === 'batch_edit' ? 'border-b-2 border-blue-500 font-medium' : 'text-neutral-500'}`}
>
Batch Edit
</button>
<button
id="batch-read-tab"
type="button"
role="tab"
aria-selected={state.type === 'read'}
aria-controls="batch-read-panel"
tabIndex={state.type === 'read' ? 0 : -1}
onClick={() => setState((prev) => ({ ...prev, type: 'read' }))}
className={`px-3 py-1 text-sm ${state.type === 'read' ? 'border-b-2 border-blue-500 font-medium' : 'text-neutral-500'}`}
>
Expand All @@ -439,8 +455,16 @@ export function BatchOperationsPanel({ onExecute, onUndo, className }: BatchOper
)}

{/* Forms */}
{state.type === 'batch_edit' && renderBatchEditForm()}
{state.type === 'read' && renderBatchReadForm()}
{state.type === 'batch_edit' && (
<div id="batch-edit-panel" role="tabpanel" aria-labelledby="batch-edit-tab">
{renderBatchEditForm()}
</div>
)}
{state.type === 'read' && (
<div id="batch-read-panel" role="tabpanel" aria-labelledby="batch-read-tab">
{renderBatchReadForm()}
</div>
)}

{/* Preview */}
{renderPreview()}
Expand Down