Skip to content

fix: localize database refresh dialog strings#24

Open
alceops wants to merge 1 commit into
nutstore:mainfrom
alceops:fix-database-refresh-i18n
Open

fix: localize database refresh dialog strings#24
alceops wants to merge 1 commit into
nutstore:mainfrom
alceops:fix-database-refresh-i18n

Conversation

@alceops
Copy link
Copy Markdown
Contributor

@alceops alceops commented May 1, 2026

Summary

  • replace the duplicate hardcoded DatabaseRefreshDialog subtitle with an i18n description key
  • replace the hardcoded refresh-button parenthetical with locale-backed text
  • add the new keys to en-US, zh-CN, ja-JP, and ko-KR

Closes #18

Verification

  • python3 static check confirmed all four locale files include databaseConnectionLostDescription and refreshPageParenthetical
  • python3 static check confirmed DatabaseRefreshDialog.tsx no longer contains the hardcoded Database Connection Lost subtitle or (Refresh Page) span text
  • git diff --check

Note: this cron VM does not have node/pnpm, so I could not run pnpm -C web run typecheck here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix duplicate untranslated string in DatabaseRefreshDialog

1 participant