Skip to content

chore: add rust formatting check to CI#2117

Merged
vigith merged 3 commits into
numaproj:mainfrom
KeranYang:fmt
Oct 3, 2024
Merged

chore: add rust formatting check to CI#2117
vigith merged 3 commits into
numaproj:mainfrom
KeranYang:fmt

Conversation

@KeranYang
Copy link
Copy Markdown
Member

@KeranYang KeranYang commented Oct 3, 2024

Tested by KeranYang#115

Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.75%. Comparing base (3dbed43) to head (39aeee9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2117      +/-   ##
==========================================
- Coverage   64.25%   63.75%   -0.51%     
==========================================
  Files         324      325       +1     
  Lines       30650    31186     +536     
==========================================
+ Hits        19695    19882     +187     
- Misses       9913    10269     +356     
+ Partials     1042     1035       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KeranYang KeranYang marked this pull request as ready for review October 3, 2024 02:03
@KeranYang KeranYang enabled auto-merge (squash) October 3, 2024 02:05
@vigith vigith disabled auto-merge October 3, 2024 02:20
@vigith
Copy link
Copy Markdown
Member

vigith commented Oct 3, 2024

We might merge this after the other PR to avoid unnecessary conflicts.

@vigith vigith enabled auto-merge (squash) October 3, 2024 13:45
@vigith vigith merged commit 772907a into numaproj:main Oct 3, 2024
@KeranYang
Copy link
Copy Markdown
Member Author

Thank you @vigith for taking care of merging!

SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants