Merged
Conversation
It was using Rails 7.2 for three 7.x test suites and 8.1 for both 8.x.
…tests Rails 8.1 moved sql_runtime from a module-level accessor on ActiveRecord::RuntimeRegistry to a nested Stats object (rails/rails@7d12071). Handle both APIs so the subscriber works on Rails <= 8.0 and >= 8.1. Rails 8.1 also logs a WARN for external redirects without allow_other_host: true, which shifted log indices in the redirect spec. Pass the flag explicitly to suppress the warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActiveRecordSubscriberfor Rails 8.1, which movedsql_runtimefrom a module-level accessor onActiveRecord::RuntimeRegistryto a nestedStatsobject (RuntimeRegistry.stats.sql_runtime)allow_other_host: true7.0.0instead of7.0) so that~>constraints pin to the intended minor version