fix: Universal cover URIs, isolated markdown parsing, and category sh…#598
Open
lalalasupa0 wants to merge 2 commits into
Open
fix: Universal cover URIs, isolated markdown parsing, and category sh…#598lalalasupa0 wants to merge 2 commits into
lalalasupa0 wants to merge 2 commits into
Conversation
Contributor
Author
|
Hey @null2264 , just gently bumping this again. Noticed the reverted the math on the Category Sheet buttons earlier. I think I figured out the cause: the sheet was calculating the layout dimensions before the views fully finished drawing on screen, leaving a transparent gap. A 1-line update that safely re-triggers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up a few minor regressions and UI/UX formatting anomalies introduced in recent system changes:
file://scheme attachments for Coil 3 on Primary Storage directories containing spaces, causingENOENTsilent failures. Prepending the scheme manually tofilePathrestores encoding compatibility across both Scoped and Primary directories without URL-encoding traps2. Category Sheet UI Dissipation (Category tab hides "cancel" and "move to" options when swiping downward #128): Re-added(?)updateBottomButtons()translation math insideSetCategoriesSheet.kt. The dynamictranslationYmath bounds the Cancel/Move buttons safely above the navigation bar, preventing them from sliding completely off-screen on devices with dense listsMangaHeaderHolderto convert<into<while utilizing negative lookaheads(?!!--)to preserve HTML comment invisibility (<!-- -->). This stopsMarkwonfrom interpreting E-Hentai tags as invisible HTML nodes. Also added a zero-width non-joiner (\u200C) escape for lone hyphens (-) and asterisks (*) to prevent single dashes from being swallowed as empty unordered list itemsChecklist
Add a 👍 reaction to pull requests you find important.