Skip to content

fix: Universal cover URIs, isolated markdown parsing, and category sh…#598

Open
lalalasupa0 wants to merge 2 commits into
null2264:masterfrom
lalalasupa0:fix-qol-batch
Open

fix: Universal cover URIs, isolated markdown parsing, and category sh…#598
lalalasupa0 wants to merge 2 commits into
null2264:masterfrom
lalalasupa0:fix-qol-batch

Conversation

@lalalasupa0
Copy link
Copy Markdown
Contributor

@lalalasupa0 lalalasupa0 commented Mar 29, 2026

Description

This PR cleans up a few minor regressions and UI/UX formatting anomalies introduced in recent system changes:

  1. Local Source Cover Resolution: Bypassing native URI generation previously broke standard file:// scheme attachments for Coil 3 on Primary Storage directories containing spaces, causing ENOENT silent failures. Prepending the scheme manually to filePath restores encoding compatibility across both Scoped and Primary directories without URL-encoding traps
    2. Category Sheet UI Dissipation (Category tab hides "cancel" and "move to" options when swiping downward #128): Re-added updateBottomButtons() translation math inside SetCategoriesSheet.kt. The dynamic translationY math bounds the Cancel/Move buttons safely above the navigation bar, preventing them from sliding completely off-screen on devices with dense lists (?)
  2. Markdown Formatting Anomalies: Added dynamic text replacements in MangaHeaderHolder to convert < into &lt; while utilizing negative lookaheads (?!!--) to preserve HTML comment invisibility (<!-- -->). This stops Markwon from interpreting E-Hentai tags as invisible HTML nodes. Also added a zero-width non-joiner (\u200C) escape for lone hyphens (-) and asterisks (*) to prevent single dashes from being swallowed as empty unordered list items

Checklist

  • Code follows project style

Add a 👍 reaction to pull requests you find important.

@lalalasupa0
Copy link
Copy Markdown
Contributor Author

Hey @null2264 , just gently bumping this again. Noticed the reverted the math on the Category Sheet buttons earlier. I think I figured out the cause: the sheet was calculating the layout dimensions before the views fully finished drawing on screen, leaving a transparent gap. A 1-line update that safely re-triggers updateBottomButtons() via a post block after the layout pass may work, which makes them snap perfectly into place without touching your other logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant