feat: support ERC1271 contract signers in MultiSigDeleGator#1
Draft
Muhammad-Altabba wants to merge 1 commit intomainfrom
Draft
feat: support ERC1271 contract signers in MultiSigDeleGator#1Muhammad-Altabba wants to merge 1 commit intomainfrom
Muhammad-Altabba wants to merge 1 commit intomainfrom
Conversation
- Added usesERC1271 mapping to track which signers are contracts vs EOAs - Modified signature verification to support mixed and nested EOA (65-byte) and ERC1271 signatures (variable length) - Added ERC1271 interface support detection Tests: - Modify old MultiSigDeleGator tests to accept ERC1271 signers - Add tests the added capabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
MultiSigDeleGatorto support ERC1271-compatible contract signers (including nested MultiSigDeleGators)usesERC1271mapping to track contract-based signersWhy?
How?
usesERC1271mapping to distinguish contract signers from EOA signers during validation[address(20)|length(2)|signatureData(variable)][r(32)|s(32)|v(1)](unchanged)addSigner/replaceSignerto validate ERC1271 support via_supportsERC1271()