Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
papazof
force-pushed
the
refactor_rewrite_and_cleanup
branch
26 times, most recently
from
b83e40b to
e1c9b5a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
papazof
force-pushed
the
refactor_rewrite_and_cleanup
branch
from
e1c9b5a to
f408ac8
Compare
papazof
force-pushed
the
refactor_rewrite_and_cleanup
branch
21 times, most recently
from
0e4e58b to
3c899ec
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ananos
approved these changes
May 9, 2025
Rewrite package modules, cleanup and modernize build process: - Move all configuration but `cffi`'s build trigger to `pyproject.toml` - Rewrite build script for `cffi` to auto-generate bindings from the `vaccel.h` header - Configure `setuptools` to build an `abi3` wheel (compatible with all Python versions >= 3.10) - Add `CType` abstract class to provide a common interface for C types - Implement wrappers based on `CType` for built-in Python types - Refactor and improve `vaccel` components based on `CType` - Rewrite `vaccel` operations as `Session` mixins - Update/extend tests and provide common `pytest` setup for environment variables and vaccel paths through `pkg-config` - Add a `classify` example with similar functionality to the C vaccel example - Improve and extend docstrings - Cleanup redundant files and code PR: #16 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Add API support for `TFLite` and `Torch` operations and relevant tests PR: #16 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Move all operation mixins to the `ops` subpackage, mirroring the vaccel C code structure PR: #16 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Add `LICENSE`, `NOTICE` and license headers to files PR: #16 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Rewrite workflows based on the vaccel repo actions and move docs generation to `nubificus/vaccel-docs` PR: #16 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Add a `run-examples.py` script to run the examples with sample inputs and configure the CI to use it PR: #16 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Update `README.md` with latest instructions PR: #16 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite package modules and extend API, cleanup, rewrite CI and modernize build process:
CTypeabstract class to provide a common interface for C types, provide wrappers for built-in types and refactorvaccelcomponentsvacceloperations asSessionmixins and move toopsTFLiteandTorchoperationspytestsetup for environment variables and vaccel paths throughpkg-configclassifyexample and a script to run the examplesnubificus/vaccel-docs