change python3 to sys.executable in tests#81
Merged
Conversation
MattZur
reviewed
Apr 28, 2026
Collaborator
MattZur
left a comment
MattZur
left a comment
There was a problem hiding this comment.
Works on Mac OS X.
Approved.
jwaiton
requested changes
Apr 28, 2026
| # this should be more complex in the future, such as if the config (which | ||
| # will be a default for the tests) returns the test flag return a number, or | ||
| # something in particular from subprocess | ||
| # something in particuelar from subprocess |
Member
There was a problem hiding this comment.
Added a funny spelling mistake, other than this, looks good! Will approve upon fixing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #78 where it was found that on a MacOS device, when using
tmux, the system defaults to a specific python version that is different from the one set by MULE.By using
sys.executablewe make the code use the exact Python binary running the test, removing dependencies ontmux, shell configs etc.