Fix: Replace 7z with ffmpeg for playable MP4 parts#18
Conversation
|
It's inconvenient to split long videos into shorter 5 minutes parts. Instead add this as an option and make it the default one without replacing the 7-zip method. Thank you for your consideration |
● ●●● Your Changes:
Hi @BraveVahid , First of all, thank you so much for taking the time to write this code and submit the Pull Request, Your core idea allowing users to download playable video parts without needing external extraction software is genuinely brilliant and heavily improves the UX for mobile users. However, after reviewing the code, I decided not to merge this PR directly due to a few critical technical and UX reasons:
How we resolved this: I am closing this PR, but I want to give you full credit for sparking this feature. Thank you again for your valuable contribution and for helping make this repository better 🩶🤚🏿 |
thank you so much for your kind and detailed review. I'm honestly just glad that I could be helpful — even if it was just an idea. |
Changes Made:
Benefits:
Technical: