feat: implement ADR-128 wiring, ADR-129 hook, ADR-130 learning extraction#201
Merged
feat: implement ADR-128 wiring, ADR-129 hook, ADR-130 learning extraction#201
Conversation
d0fa5f9 to
5be0dc3
Compare
…tion ADR-129: Add posttool-rename-sweep.py hook that detects git mv commands and greps for stale references to old filenames across .py/.json/.md/.yaml files. Prevents the class of bug that broke 83 tests in ADR-118. ADR-130: Extend pause-work with Phase 3 (EXTRACT LEARNINGS) that queries learning.db for session insights, filters for ADR-worthy decisions using a decision-vs-tip heuristic, and drafts skeleton ADRs with Proposed status. ADR-128: Wire joy-check instruction mode into skill-creation-pipeline (Phase 4 Step 3) and agent-upgrade (Phase 4 Step 2.5) so new/modified skills and agents are validated for positive framing automatically.
5be0dc3 to
e7f9a51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements three independent ADRs from the post-127/128 rollout follow-up:
hooks/posttool-rename-sweep.py— PostToolUse hook that detectsgit mvcommands and greps for stale references to old filenames across.py/.json/.md/.yaml/.ymlfiles. Prevents the class of bug that broke 83 tests during ADR-118 renames.skills/pause-work/SKILL.md— New Phase 3 (EXTRACT LEARNINGS) querieslearning-db.pyfor session insights, filters ADR-worthy decisions using a decision-vs-tip heuristic, and drafts skeleton ADRs with Proposed status. Renumbers subsequent phases (4: WRITE, 5: CONFIRM).joy-check --mode instructionintoskill-creation-pipeline(Phase 4, Step 3) andagent-upgrade(Phase 4, Step 3) so new/modified skills and agents are automatically validated for positive framing.All three were implemented by parallel agents with file partitioning (non-overlapping files, no worktrees needed).
Review fixes applied
git mv -f/--forceflags and quoted paths with spacestool_result.is_errorto skip failed git mv commands--include=*.yml, minimum stem length guard (3 chars), and self-match filteringTest plan
py_compile)