Skip to content

feat: implement ADR-128 wiring, ADR-129 hook, ADR-130 learning extraction#201

Merged
notque merged 1 commit intomainfrom
feat/adr-128-129-130-implementations
Mar 28, 2026
Merged

feat: implement ADR-128 wiring, ADR-129 hook, ADR-130 learning extraction#201
notque merged 1 commit intomainfrom
feat/adr-128-129-130-implementations

Conversation

@notque
Copy link
Copy Markdown
Owner

@notque notque commented Mar 28, 2026

Summary

Implements three independent ADRs from the post-127/128 rollout follow-up:

  • ADR-129: hooks/posttool-rename-sweep.py — PostToolUse hook that detects git mv commands and greps for stale references to old filenames across .py/.json/.md/.yaml/.yml files. Prevents the class of bug that broke 83 tests during ADR-118 renames.
  • ADR-130: skills/pause-work/SKILL.md — New Phase 3 (EXTRACT LEARNINGS) queries learning-db.py for session insights, filters ADR-worthy decisions using a decision-vs-tip heuristic, and drafts skeleton ADRs with Proposed status. Renumbers subsequent phases (4: WRITE, 5: CONFIRM).
  • ADR-128 wiring: Connects joy-check --mode instruction into skill-creation-pipeline (Phase 4, Step 3) and agent-upgrade (Phase 4, Step 3) so new/modified skills and agents are automatically validated for positive framing.

All three were implemented by parallel agents with file partitioning (non-overlapping files, no worktrees needed).

Review fixes applied

  • Hook regex updated to handle git mv -f/--force flags and quoted paths with spaces
  • Hook now checks tool_result.is_error to skip failed git mv commands
  • Added --include=*.yml, minimum stem length guard (3 chars), and self-match filtering
  • Resolved contradictory blocking guidance in skill-creation-pipeline (joy-check is advisory)
  • Renumbered Step 2.5 → Step 3 in agent-upgrade for consistency

Test plan

  • Hook Python syntax validates (py_compile)
  • Hook regex tested: simple, paths, chained, flags (-f, --force), quoted spaces
  • Hook is_error guard, stem length guard, self-match filter verified
  • Pause-work phases correctly renumbered (3→4→5), gates present
  • Pipeline joy-check steps inserted at correct locations
  • All step numbering consistent (no fractional steps)

@notque notque force-pushed the feat/adr-128-129-130-implementations branch from d0fa5f9 to 5be0dc3 Compare March 28, 2026 15:22
…tion

ADR-129: Add posttool-rename-sweep.py hook that detects git mv commands
and greps for stale references to old filenames across .py/.json/.md/.yaml
files. Prevents the class of bug that broke 83 tests in ADR-118.

ADR-130: Extend pause-work with Phase 3 (EXTRACT LEARNINGS) that queries
learning.db for session insights, filters for ADR-worthy decisions using
a decision-vs-tip heuristic, and drafts skeleton ADRs with Proposed status.

ADR-128: Wire joy-check instruction mode into skill-creation-pipeline
(Phase 4 Step 3) and agent-upgrade (Phase 4 Step 2.5) so new/modified
skills and agents are validated for positive framing automatically.
@notque notque force-pushed the feat/adr-128-129-130-implementations branch from 5be0dc3 to e7f9a51 Compare March 28, 2026 15:26
@notque notque merged commit f98e85a into main Mar 28, 2026
4 checks passed
@notque notque deleted the feat/adr-128-129-130-implementations branch March 28, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant