Skip to content

Ajustes na implementação do ULID #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RafaJEstabile wants to merge 1 commit into from
+21 −4
Closed

Ajustes na implementação do ULID #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/Ulid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,18 @@ class Ulid
* @param string $ulid
* @return bool
*/
public function isValidFormat(
string $ulid
): bool {
public function isValidFormat(string $ulid): bool
{
$validator = UlidConstants::TIME_LENGTH + UlidConstants::RANDOM_LENGTH;

if (strlen($ulid) !== $validator) {
return false;
}
return true;

return preg_match(
UlidConstants::REGEX,
$ulid
) === 1;
}

/**
Expand Down
1 change: 1 addition & 0 deletions src/UlidConstants.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ class UlidConstants
const TIME_MAX = 281474976710655;
const TIME_LENGTH = 10;
const RANDOM_LENGTH = 16;
const REGEX = '/^[0-9A-HJKMNP-TV-Z]{26}$/ ';
}
12 changes: 12 additions & 0 deletions tests/UlidTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,18 @@ public function testDecodeTimeInvalidTime()
$ulid->decodeTime('QS234SAD23RADSWRA3FADQ3RS2');
}

/**
* @covers Ulid\Ulid::isValidFormat
*/
public function testIsValidFormatDoesNotValidateCharacters()
{
$ulid = new Ulid();

$result = $ulid->isValidFormat('01E475VQGHNW990PVHXFDT4C6W');

$this->assertTrue($result);
}

protected function tearDown(): void
{
//
Expand Down