refacror & feature: add tracering, supporting chrome trace, refactor execution graph validator, polishing tests.#106
Conversation
noneback
force-pushed
the
agent
branch
2 times, most recently
from
588f033 to
10cc43e
Compare
- extract Option type and With* funcs into options.go - add WithConcurrency, WithProfiler, WithTracer, WithPanicHandler options - internalize validator (unexported types, package-level func) - fix data race in TestTaskflowNotInFlow (atomic.Int32) - fix data race in TestPoolSequentialExec (sync.WaitGroup) - update README and llms.txt with Options and Tracing sections
- merge double log.Printf per panic into single structured line - use %q for graph/task names, add [go-taskflow] prefix - remove internal scheduler noise logs (node-skip, subgraph-cancel propagation)
- add traceRecord type and tracer.snapshot() to tracer.go - validate() now takes traceRecord (immutable snapshot) instead of Executor - validator struct holds traceRecord, no longer locks tracer directly - add mustSnapshot() test helper to extract snapshot from executor - nil traceRecord treated as 'no trace data', always returns valid
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 89.07% 88.99% -0.08%
==========================================
Files 13 16 +3
Lines 659 827 +168
==========================================
+ Hits 587 736 +149
- Misses 53 66 +13
- Partials 19 25 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.