Implement various DEREncoding methods#22
Open
jonathanverner wants to merge 1 commit into
Open
Conversation
This commit provides implementation for the following
DEREncode methods:
RdnValue::DEREncode
DateValue::DEREncode
ExtensionValue::DEREncode
KeyIdentifierValue::DEREncode
BasicConstraintValue::BERDecode
Notably, it does not implement the
X509Certificate::DEREncode
method, which is the main missing part for being
able to go back-and-forth between a CryptoPP cert
and its DER-encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit provides implementation for the following DEREncode methods:
Notably, it does not implement the
method, which is the main missing part for being able to go back-and-forth between a CryptoPP cert
and its DER-encoding.
The commit is still useful, e.g., for returning certificate attributes in a PKCS#11 which are supposed to
be DER-encoded, e.g. to return a
CKA_START_DATEof a certificate, one can just write: