Add .dockerignore file to exclude build artifacts.#10
Open
nachomata wants to merge 1 commit intonokia:mainfrom
Open
Add .dockerignore file to exclude build artifacts.#10nachomata wants to merge 1 commit intonokia:mainfrom
nachomata wants to merge 1 commit intonokia:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a
.dockerignorefile to reduce the build context size and speed up the build process with Docker.When building the Corteca CLI using Docker, it may take some extra time transferring the build context to the Docker daemon - especially due to the size of the
distdirectory with the build artifacts.Performance comparison (personal scenario):
COPY . .COPY . .COPY . .COPY . .I realize there may be additional files or directories that could also be added to the
.dockerignorelist. But to keep it simple and easy to review I only added the entries from the.gitignore, with primary focus on excluding thedistfolder, as it is the largest contributor to the build context size.Feedback is welcome!