feat(mocha-to-node-test-runner): migrate mocha@8.x to node:test (v22, v24+)

[Xstoudi]

Should fix #103

[AugustinMauroy]

Oh nice that really cool !

Few points that can be improved:

• md format on readme
• little bit of JSdoc
• small missing unit test

[Xstoudi]

I wrote test for is-esm, let me know if you see something is missing.

I applied your recommendations then reverted two of them:

• one was changing logic wrongly
• replacing array.length === 0 with !array.length make it less readable, I'd prefer to avoid doing so

Let me now if there is anything else.

[AugustinMauroy]

maybe add an other it that use arrow function as call back
and a fonction as arg like

function myBasicTest = () => {
  assert(true)
}

The second case will be can super complicated to migrate.
in a first time let's just have test that proof that's ins't handled and document it.
In second time (follow up pr) having systems that handle this case. The logic to catch a refercen is already furnished by the codemod context https://docs.codemod.com/jssg/semantic-analysis

[Xstoudi]

Let me know if anything more is required.

[AugustinMauroy]

LGMT ! for the code transformation part missing the removing dep you should take code from chalk-to-styletext.

[Xstoudi]

Added that, let me know if something is missing.

[AugustinMauroy]

For me it's good ! we need to wait a second approval to land !

[AugustinMauroy]

F*ck what happened here. !Windows!

cc @nodejs/userland-migrations any idea

[AugustinMauroy]

hey 👋 @Xstoudi

[AugustinMauroy]

LGTM ! I stil don't get why windows give this error
Maybe use lower comparison level on testing https://docs.codemod.com/jssg/testing#strictness-levels

[brunocroh]

LGTM

[JakobJingleheimer]

The windows testing is failing with:

---- tests_7_timeouts.js ----
Output mismatch for test 'tests_7_timeouts.js':
-const assert = require('assert');
-const { describe, it } = require('node:test');
-describe('Timeout Test', { timeout: 500 }, function() {
-
-	it('should complete within 100ms', { timeout: 100 }, (t, done) => {
-		setTimeout(done, 500); // This will fail
-	});
-
-	it('should complete within 200ms', { timeout: 200 }, function(t, done) {
-		setTimeout(done, 100); // This will pass
-	});
-});

Where it looks like the entire contents of the expected file isn't there. @mohebifar have you seen anything like this before?

[JakobJingleheimer]

Thanks for this! 🙌

A few nits here and there.

For the test files, could the names please be more descriptive (eg 3_hooks is not so illuminating).

Also, there are 2 options for organising test files. We do have a bit of a mix, but option 1 is far superior to the "junk-drawer" option 2. Would you mind adjusting these to option 1? If you don't want to bother with it, that's fine—but would you mind if one of us made the adjustment within this PR?

I haven't reviewed the test cases yet because it's so cumbersome with option 2.

[AugustinMauroy]

The windows testing is failing with:

---- tests_7_timeouts.js ----
Output mismatch for test 'tests_7_timeouts.js':
-const assert = require('assert');
-const { describe, it } = require('node:test');
-describe('Timeout Test', { timeout: 500 }, function() {
-
-	it('should complete within 100ms', { timeout: 100 }, (t, done) => {
-		setTimeout(done, 500); // This will fail
-	});
-
-	it('should complete within 200ms', { timeout: 200 }, function(t, done) {
-		setTimeout(done, 100); // This will pass
-	});
-});

Where it looks like the entire contents of the expected file isn't there. @mohebifar have you seen anything like this before?

Windows didn't encode tab like unix and I assume the test file was written with unix like OS