Skip to content

types: remove legacy AbortSignal alias now provided by @types/node#4995

Merged
mcollina merged 1 commit intonodejs:mainfrom
trivikr:remove-abort-signal
Apr 8, 2026
Merged

types: remove legacy AbortSignal alias now provided by @types/node#4995
mcollina merged 1 commit intonodejs:mainfrom
trivikr:remove-abort-signal

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented Apr 8, 2026

This relates to...

N/A

Rationale

This alias was originally added in #482 before @types/node exposed AbortSignal, but that is no longer necessary. Relying on the upstream type definition keeps the dispatcher typings simpler and avoids maintaining a redundant alias.

Changes

Remove the local AbortSignal alias from types/dispatcher.d.ts.

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (51cc6cb) to head (c2320be).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4995   +/-   ##
=======================================
  Coverage   92.86%   92.87%           
=======================================
  Files         110      110           
  Lines       35788    35788           
=======================================
+ Hits        33236    33238    +2     
+ Misses       2552     2550    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 08a480b into nodejs:main Apr 8, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants