fix: remove stale constructor interceptors from types and pool options#4994
Open
trivikr wants to merge 1 commit intonodejs:mainfrom
Open
fix: remove stale constructor interceptors from types and pool options#4994trivikr wants to merge 1 commit intonodejs:mainfrom
trivikr wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4994 +/- ##
=======================================
Coverage 92.86% 92.87%
=======================================
Files 110 110
Lines 35788 35779 -9
=======================================
- Hits 33236 33229 -7
+ Misses 2552 2550 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #4993
Rationale
#3399 removed constructor interceptor support at runtime, but the public type declarations still exposed
interceptorsonClient,Pool,RoundRobinPool, andAgent.That left a type/runtime mismatch: TypeScript accepted these options even though they were no longer consumed.
Changes
interceptorsfrom the publicClient.Options,Pool.Options,RoundRobinPool.Options, andAgent.Optionstype declarations.options.interceptorscopying that was still present in pool constructors.tsdcoverageFeatures
N/A
Bug Fixes
Breaking Changes and Deprecations
A type-level breaking change for consumers still passing these unsupported options.
Status