refactor: reuse wrapRequestBody in RedirectHandler#4992
Merged
mcollina merged 1 commit intonodejs:mainfrom Apr 8, 2026
Merged
Conversation
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4992 +/- ##
==========================================
+ Coverage 92.86% 92.92% +0.05%
==========================================
Files 110 110
Lines 35788 35738 -50
==========================================
- Hits 33236 33210 -26
+ Misses 2552 2528 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Reuse
wrapRequestBodywritten in #3294Rationale
RedirectHandlerduplicated request body wrapping and disturbance tracking logic that already exists inlib/core/util.jsaswrapRequestBody(). Reusing the shared helper brings redirect handling onto the same path as retry handling and reduces the risk of the two implementations drifting.Changes
util.wrapRequestBody()inRedirectHandlerBodyAsyncIterableand duplicated stream disturbance handling fromredirect-handler.jsFeatures
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status