fix(retry-handler): validate response body length against Content-Range#4975
Open
fix(retry-handler): validate response body length against Content-Range#4975
Conversation
The RetryHandler was validating the Content-Range header when resuming a response via Range request, but not verifying that the actual response body length matched the claimed range. This fix validates in onResponseEnd() that when there's a finite end position (from Content-Length or Content-Range), the cumulative bytes received (this.start) equals this.end + 1. If not, a RequestRetryError is thrown with message 'Content-Range mismatch'. Fixes: #4970
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4975 +/- ##
==========================================
- Coverage 92.96% 92.87% -0.09%
==========================================
Files 111 110 -1
Lines 35842 35793 -49
==========================================
- Hits 33320 33243 -77
- Misses 2522 2550 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4970