feat: support external module resolution from webpack bundle#121
Open
wpessers wants to merge 7 commits intonodejs:mainfrom
Open
feat: support external module resolution from webpack bundle#121wpessers wants to merge 7 commits intonodejs:mainfrom
wpessers wants to merge 7 commits intonodejs:mainfrom
Conversation
Author
…versions The npm is node 12.0 is not sufficient to install a working webpack-cli.
Error (from CI run) is:
> webpack --config test/webpack/webpack.config.js && node test/webpack/dist/bundle.js # requires Node.js >=10.8, >=12.?
[webpack-cli] Error: Cannot find module 'ajv/dist/compile/codegen'
Require stack:
- /home/runner/work/require-in-the-middle/require-in-the-middle/node_modules/ajv-keywords/dist/definitions/typeof.js
- /home/runner/work/require-in-the-middle/require-in-the-middle/node_modules/ajv-keywords/dist/keywords/typeof.js
...
Contributor
|
Though webpack-cli says it supports recent Node.js 14 versions, I gather we probably don't particularly care and can just test with Node.js 16 and later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #120
Very short summary of that issue:
Had some time to revisit this after a long while. Will still do some real-world testing as well but this could be a proper fix for the issue, if maintainers would choose to accept it. For the test setup I've based myself a lot on the existing babel test. And I used the
semverpackage as external dependency in that test since it's already a devDependency as well.