Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/ui-components/src/Common/Select/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { ChevronDownIcon, ChevronUpIcon } from '@heroicons/react/24/outline';
import * as SelectPrimitive from '@radix-ui/react-select';
import classNames from 'classnames';
import { useId, useMemo, useState } from 'react';
import { useEffect, useId, useMemo, useState } from 'react';

import Skeleton from '#ui/Common/Skeleton';

Expand Down Expand Up @@ -64,6 +64,8 @@
const id = useId();
const [value, setValue] = useState(defaultValue);

useEffect(() => setValue(defaultValue), [defaultValue]);

Check warning on line 67 in packages/ui-components/src/Common/Select/index.tsx

View workflow job for this annotation

GitHub Actions / Quality checks

Do not call the 'set' function 'setValue' of 'useState' synchronously in an effect. This can lead to unnecessary re-renders and performance issues

const mappedValues = useMemo(() => mapValues(values), [values]) as Array<
SelectGroup<T>
>;
Expand Down
Loading