Skip to content

tools: allow triagers to queue a PR for CI until it's reviewed#62524

Merged
aduh95 merged 1 commit intonodejs:mainfrom
aduh95:auto-start-ci-later
Apr 2, 2026
Merged

tools: allow triagers to queue a PR for CI until it's reviewed#62524
aduh95 merged 1 commit intonodejs:mainfrom
aduh95:auto-start-ci-later

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Mar 31, 2026

Triagers and PR authors currently have to wait until a PR has gotten an approving review before applying the request-ci Add this label to start a Jenkins CI on a PR. label; this change allows to add the label immediately, and the CI will start once the PR is approved.

Fixes: #62496

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 31, 2026
@panva panva requested a review from Copilot March 31, 2026 15:40
@panva
Copy link
Copy Markdown
Member

panva commented Mar 31, 2026

misclicked Copilot review >,<

@panva panva review requested due to automatic review settings March 31, 2026 15:41
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 2, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 2, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/62524
✔  Done loading data for nodejs/node/pull/62524
----------------------------------- PR info ------------------------------------
Title      tools: allow triagers to queue a PR for CI until it's reviewed (#62524)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:auto-start-ci-later -> nodejs:main
Labels     meta, author ready
Commits    2
 - tools: allow triagers to queue a PR for CI until it's reviewed
 - fixup! tools: allow triagers to queue a PR for CI until it's reviewed
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62524
Fixes: https://github.com/nodejs/node/issues/62496
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62524
Fixes: https://github.com/nodejs/node/issues/62496
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 31 Mar 2026 14:38:17 GMT
   ✔  Approvals: 2
   ✔  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/62524#pullrequestreview-4038334063
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/62524#pullrequestreview-4048612983
   ✘  1 GitHub CI job(s) cancelled:
   ✘    - Agent: CANCELLED (https://github.com/nodejs/node/actions/runs/23806086534/job/69379833628)
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/23906007514

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Apr 2, 2026

misclicked Copilot review >,<

Interestingly that makes the CQ fail, oh well

PR-URL: nodejs#62524
Fixes: nodejs#62496
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95 aduh95 force-pushed the auto-start-ci-later branch from 89f1212 to 25443db Compare April 2, 2026 14:48
@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Apr 2, 2026

Landed in 25443db

@aduh95 aduh95 merged commit 25443db into nodejs:main Apr 2, 2026
13 checks passed
@aduh95 aduh95 deleted the auto-start-ci-later branch April 2, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a label to note “this is good for CI”

5 participants