Skip to content

meta: require DCO signoff in commit message guidelines #62510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasnell wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −0
Open

meta: require DCO signoff in commit message guidelines #62510

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d641fb3
meta: require DCO signoff in commit message guidelines
jasnell Mar 30, 2026
804006b
Apply suggestion from @jasnell
jasnell Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions doc/contributing/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,14 @@ A good commit message should describe what changed and why.
contain an explanation about the reason of the breaking change, which
situation would trigger the breaking change, and what is the exact change.

6. Your commit must contain the `Signed-off-by` line with your name and email
address as an acknowledgement that you agree to the [Developer Certificate of Origin][].
Bot generated commits are exempt from this requirement. If a commit has
multiple authors, the `Signed-off-by` line should be added for each author;
and at least one should match the author information in the commit metadata.
This rule does not apply to dependency updates (e.g. cherry-picks), release
commits, or backport commits.

Sample complete commit message:

```text
Expand All @@ -210,6 +218,7 @@ less.

Fixes: https://github.com/nodejs/node/issues/1337
Refs: https://eslint.org/docs/rules/space-in-parens.html
Signed-off-by: J. Random User <j.random.user@example.com>
```

If you are new to contributing to Node.js, please try to do your best at
Expand Down Expand Up @@ -594,6 +603,7 @@ More than one subsystem may be valid for any particular issue or pull request.
[Building guide]: ../../BUILDING.md
[CI (Continuous Integration) test run]: #continuous-integration-testing
[Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
[Developer Certificate of Origin]: ../../CONTRIBUTING.md#developers-certificate-of-origin-11
[Onboarding guide]: ../../onboarding.md
[approved]: #getting-approvals-for-your-pull-request
[benchmark results]: writing-and-running-benchmarks.md
Expand Down
Loading