Skip to content

lib: fix sequence argument handling in Blob constructor#62179

Open
Ms2ger wants to merge 1 commit intonodejs:mainfrom
Ms2ger:blob-sequence
Open

lib: fix sequence argument handling in Blob constructor#62179
Ms2ger wants to merge 1 commit intonodejs:mainfrom
Ms2ger:blob-sequence

Conversation

@Ms2ger
Copy link
Copy Markdown
Contributor

@Ms2ger Ms2ger commented Mar 10, 2026

This uses the existing WebIDL infrastructure to handle the iteration over the argument correctly according to the specification.

Note that we can't avoid looping over the input twice: we only know the value of the 'endings' option after converting the blob parts into an array.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 10, 2026
@Ms2ger Ms2ger force-pushed the blob-sequence branch 2 times, most recently from 43be7a6 to d4ac3a5 Compare March 10, 2026 13:41
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (e419afd) to head (be62641).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62179      +/-   ##
==========================================
- Coverage   89.71%   89.71%   -0.01%     
==========================================
  Files         695      695              
  Lines      214441   214445       +4     
  Branches    41062    41051      -11     
==========================================
- Hits       192384   192383       -1     
+ Misses      14123    14115       -8     
- Partials     7934     7947      +13     
Files with missing lines Coverage Δ
lib/internal/blob.js 99.44% <100.00%> (+<0.01%) ⬆️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MattiasBuelens MattiasBuelens added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

This uses the existing WebIDL infrastructure to handle the iteration
over the argument correctly according to the specification.

Note that we can't avoid looping over the input twice: we only know the
value of the 'endings' option after converting the blob parts into an
array.
@jazelly jazelly added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants