test_runner: add classname hierarchy for JUnit reporter#60220
Open
mag123c wants to merge 1 commit intonodejs:mainfrom
Open
test_runner: add classname hierarchy for JUnit reporter#60220mag123c wants to merge 1 commit intonodejs:mainfrom
mag123c wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
atlowChemi
approved these changes
Oct 12, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60220 +/- ##
=======================================
Coverage 89.71% 89.71%
=======================================
Files 695 695
Lines 214441 214455 +14
Branches 41056 41065 +9
=======================================
+ Hits 192376 192402 +26
+ Misses 14113 14108 -5
+ Partials 7952 7945 -7
🚀 New features to boost your workflow:
|
f738875 to
5e2a5d3
Compare
|
Hello @MoLow @pmarchini Could you take a look? Thank you. |
Collaborator
Collaborator
pmarchini
approved these changes
Jan 25, 2026
5e2a5d3 to
175d312
Compare
|
Hello @MoLow Could you take a look? Thank you. |
MoLow
approved these changes
Mar 25, 2026
175d312 to
e245584
Compare
MoLow
approved these changes
Apr 5, 2026
Member
|
@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time |
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/71009/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002251583 |
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Querying data for job/node-test-pull-request/71009/ [SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24002689464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #59417
Implements classname hierarchy for the JUnit XML reporter.
Previously, all tests had
classname="test".Now the classname reflects the suite hierarchy (e.g.,
classname="Math.Addition"for nested suites).