Skip to content

test_runner: add classname hierarchy for JUnit reporter#60220

Open
mag123c wants to merge 1 commit intonodejs:mainfrom
mag123c:feature/junit-classname-hierarchy
Open

test_runner: add classname hierarchy for JUnit reporter#60220
mag123c wants to merge 1 commit intonodejs:mainfrom
mag123c:feature/junit-classname-hierarchy

Conversation

@mag123c
Copy link
Copy Markdown
Contributor

@mag123c mag123c commented Oct 12, 2025

Fixes: #59417

Implements classname hierarchy for the JUnit XML reporter.
Previously, all tests had classname="test".
Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 12, 2025
@atlowChemi atlowChemi requested review from MoLow and pmarchini October 12, 2025 20:10
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (2593291) to head (e245584).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60220   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files         695      695           
  Lines      214441   214455   +14     
  Branches    41056    41065    +9     
=======================================
+ Hits       192376   192402   +26     
+ Misses      14113    14108    -5     
+ Partials     7952     7945    -7     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.96% <100.00%> (+0.02%) ⬆️
lib/internal/test_runner/tests_stream.js 87.97% <100.00%> (+0.13%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mag123c mag123c force-pushed the feature/junit-classname-hierarchy branch from f738875 to 5e2a5d3 Compare October 13, 2025 00:26
@CuriousStork
Copy link
Copy Markdown

Hello @MoLow @pmarchini

Could you take a look? Thank you.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@mag123c mag123c force-pushed the feature/junit-classname-hierarchy branch from 5e2a5d3 to 175d312 Compare January 26, 2026 00:48
@CuriousStork
Copy link
Copy Markdown

Hello @MoLow

Could you take a look? Thank you.

@mag123c mag123c force-pushed the feature/junit-classname-hierarchy branch from 175d312 to e245584 Compare April 4, 2026 03:59
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 5, 2026
@MoLow
Copy link
Copy Markdown
Member

MoLow commented Apr 5, 2026

@mag123c, please avoid pushing new commits if unnececary as it requires an entire CI cycle every time

@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/24002251583

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Apr 5, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71009/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/24002689464

@github-actions github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

7 participants