feat(cmake): add option for disabling tests#15
Merged
aduh95 merged 1 commit intonodejs:mainfrom Apr 9, 2026
Merged
Conversation
7 tasks
aduh95
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project's
CMakeLists.txtto improve how testing is enabled and managed. The main changes introduce a new option for controlling test builds, conditionally include test dependencies and directories, and improve reproducibility by specifying a hash for thegoogletestdependency.Testing configuration improvements:
NBYTES_ENABLE_TESTINGto control whether testing is enabled, defaulting to the value ofBUILD_TESTING(option(NBYTES_ENABLE_TESTING "Enable testing" ${BUILD_TESTING})).testssubdirectory and fetchesgoogletestif testing is enabled, making test dependencies optional for non-testing builds.googletestdependency to ensure consistent and secure downloads.General build system improvements:
srcsubdirectory to occur before the conditional test logic, ensuring core sources are always included.PS: Only the pr description was generated via ai.
PPS: Tests are on by default and can be controlled via BUILD_TESTING or NBYTES_ENABLE_TESTING.