Another which-key keymap based replacements implementation#482
Open
leifhelm wants to merge 2 commits intonoctuid:masterfrom
Open
Another which-key keymap based replacements implementation#482leifhelm wants to merge 2 commits intonoctuid:masterfrom
leifhelm wants to merge 2 commits intonoctuid:masterfrom
Conversation
Owner
|
I will look at both your PRs next week, but if they both work, I will probably go with yours once tests are working since it is simpler. |
noctuid
reviewed
Jul 27, 2021
Owner
noctuid
left a comment
There was a problem hiding this comment.
I think completely replacing the old mechanism should be okay since all the regexps were auto-generated and not complicated (no functionality should be lost).
The only issue is that this needs to handle :definer 'minor-mode (should check kargs to determine whether to pass t for the next argument to general--get-keymap).
If you want to fix the minor mode issue, go ahead. I can take care of the tests and documentation.
Left to be done:
- fix handling for
evil-define-minor-mode-key - rewrite all tests to inspect keymaps instead
- rewrite documentation; mention old keywords are deprecated and date which-key implemented this functionality
noctuid
reviewed
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started working on implementing which-key keymap based replacements at the same time as @jgrey4296 (#481) as suggested in #193.
As I am no expert in programming with emacs lisp I choose to use
which-key-add-keymap-based-replacements.I did not correct the which-key tests yet.