Skip to content

Bump connector to unskip issuance with request test #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Magnus-Kuhn wants to merge 2 commits into
base: release/openid4vc
Choose a base branch
from
Draft

Bump connector to unskip issuance with request test #987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5e3d21
test: unskip issuance with request
Magnus-Kuhn Mar 6, 2026
9a1adb0
Merge branch 'release/openid4vc' into unskip-request-issuance
mergify[bot] Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .dev/compose.openid4vc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ services:
- default

connector:
image: ghcr.io/nmshd/connector:7.4.0-openid4vc.2@sha256:d121f97ce2e4506a7ff58de0012b3445f6d0aeb8dd4d765c09da7f34d8a22b5b
image: ghcr.io/nmshd/connector:7.4.0-openid4vc.3@sha256:5515c68664e7d87430fde49fc0467b956dd713567b31bbd6c235502eaa8a8ec4
environment:
CUSTOM_CONFIG_LOCATION: "/config.json"
transportLibrary__baseUrl: ${NMSHD_TEST_BASEURL}
Expand Down
4 changes: 1 addition & 3 deletions packages/runtime/test/consumption/openid4vc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,7 @@ describe("EUDIPLO", () => {
expect(presentationResult.value.status).toBe(200);
});

// TODO: unskip once fix to CanCreateShareCredentialOffer has been deployed to the connector
// eslint-disable-next-line jest/no-disabled-tests
test.skip("issuance with request", async () => {
test("issuance with request", async () => {
const oldCredentials = (
await runtimeServices1.consumption.attributes.getAttributes({
query: {
Expand Down
Loading