docs: remove unnecessary template before get in README & docs (fixes #4825)#4920
docs: remove unnecessary template before get in README & docs (fixes #4825)#4920aryanrahar wants to merge 1 commit intonlohmann:developfrom
Conversation
|
Can you take a look at the PR will turn the DCO green once all checks are passed! |
|
Please rebase to the latest develop branch so the CI can run successfully. Also please check https://github.com/nlohmann/json/pull/4920/checks?check_run_id=50274941755 |
|
Hi @aryanrahar, can you please rebase? |
|
Actually my midsem exams are going i will do the work in 1-2 days!
…On Sat, 20 Sep 2025 at 8:09 PM, Niels Lohmann ***@***.***> wrote:
*nlohmann* left a comment (nlohmann/json#4920)
<#4920 (comment)>
Hi @aryanrahar <https://github.com/aryanrahar>, can you please rebase?
—
Reply to this email directly, view it on GitHub
<#4920 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BU52OI37IHVKF43B7B7HJGT3TVRIRAVCNFSM6AAAAACGMH6RHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJVGAYDQOJTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No worries - good luck to you! 🍀 |
b626754 to
3ab4582
Compare
|
Can you approve the change? |
|
is there any issue? |
|
Can you please rebase to the latest |
…ADME & MkDocs (fixes nlohmann#4825) Signed-off-by: aryanrahar <aryanrahar1@gmail.com>
3ab4582 to
41a0fee
Compare
|
Done
done |
|
I just merged #4846 which worked on the same issue. Please rebase your branch to see whether there is anything left to do. |
|
This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions! |
Description
This pull request resolves issue #4825 by removing the unnecessary template keyword from get() calls in non-dependent contexts throughout the README and MkDocs documentation.
What
Replaced .template get<...>() with .get<...>() in documentation examples where it was not required.
No library code was changed.
Why
Improves the clarity and correctness of the code examples for users.
The .template keyword is only necessary for dependent names in C++ templates and can be confusing when used outside of that context.
How Tested
Successfully built and previewed the documentation locally using mkdocs.
Ran the full CTest suite as a courtesy check to ensure no regressions were introduced.