build(deps): bump @nl-design-system-unstable/start-design-tokens from 2.4.1 to 5.1.0#667
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ea19f21 to
a4366a1
Compare
|
This PR is blocked because of a known contrast issue that we need a solution for (ignore or fix): |
Bumps [@nl-design-system-unstable/start-design-tokens](https://github.com/nl-design-system/themes/tree/HEAD/packages/start-design-tokens) from 2.4.1 to 5.1.0. - [Release notes](https://github.com/nl-design-system/themes/releases) - [Changelog](https://github.com/nl-design-system/themes/blob/main/packages/start-design-tokens/CHANGELOG.md) - [Commits](https://github.com/nl-design-system/themes/commits/@nl-design-system-unstable/voorbeeld-design-tokens@5.1.0/packages/start-design-tokens) --- updated-dependencies: - dependency-name: "@nl-design-system-unstable/start-design-tokens" dependency-version: 5.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
a4366a1 to
f7689f7
Compare
|
Relevant thread in Slack channel: https://codefornl.slack.com/archives/C01D78C2E4E/p1775739878038599
TL;DR: the component that this contrast issue applies to shows no text whatever the circumstances, so in this case it seems a false positive. I'm going to opt for an |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 88.06% 84.50% -3.56%
==========================================
Files 57 71 +14
Lines 1701 2169 +468
Branches 378 494 +116
==========================================
+ Hits 1498 1833 +335
- Misses 166 279 +113
- Partials 37 57 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- all major updates for `@amsterdam` packages - remove unused dependency from theme-wizard-app - fix: upgrading start tokens in #667 broke the custom property mapping of clippy-modal because the `todo.modal-dialog.*` tokens were [removed in v3.0.0](https://github.com/nl-design-system/themes/blob/main/packages/start-design-tokens/CHANGELOG.md#300). Removing this broken mapping fixes the issue. <img width="778" height="314" alt="Screenshot 2026-04-09 at 21 41 09" src="https://github.com/user-attachments/assets/7cd7fbc9-cbe1-4387-acf0-2f45ebbf9a2d" /> - [x] I did visual regression more thoroughly this time --------- Co-authored-by: Bram Smulders <source@bram.is>




Bumps @nl-design-system-unstable/start-design-tokens from 2.4.1 to 5.1.0.
Changelog
Sourced from
@nl-design-system-unstable/start-design-tokens's changelog.... (truncated)
Commits