Skip to content

build(deps): bump @nl-design-system-unstable/start-design-tokens from 2.4.1 to 5.1.0#667

Merged
bartveneman merged 4 commits intomainfrom
dependabot/npm_and_yarn/nl-design-system-unstable/start-design-tokens-5.1.0
Apr 9, 2026
Merged

build(deps): bump @nl-design-system-unstable/start-design-tokens from 2.4.1 to 5.1.0#667
bartveneman merged 4 commits intomainfrom
dependabot/npm_and_yarn/nl-design-system-unstable/start-design-tokens-5.1.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 2, 2026

Bumps @nl-design-system-unstable/start-design-tokens from 2.4.1 to 5.1.0.

Changelog

Sourced from @​nl-design-system-unstable/start-design-tokens's changelog.

5.1.0

Minor Changes

  • 50d3bda: Add utrecht.document tokens.

Patch Changes

  • 4defe5e: Remove hardcoded icon color. Color should depend on context.

5.0.0

Major Changes

  • 9c4c9e6: De volgende tokens zijn toegevoegd aan Switch component:

    • utrecht.form-toggle.accent-color
    • utrecht.form-toggle.background-color
    • utrecht.form-toggle.border-color
    • utrecht.form-toggle.border-radius
    • utrecht.form-toggle.border-style
    • utrecht.form-toggle.border-width
    • utrecht.form-toggle.color
    • utrecht.form-toggle.height
    • utrecht.form-toggle.padding-block-end
    • utrecht.form-toggle.padding-block-start
    • utrecht.form-toggle.padding-inline-end
    • utrecht.form-toggle.padding-inline-start
    • utrecht.form-toggle.width
    • utrecht.form-toggle.checked.accent-color
    • utrecht.form-toggle.disabled.border-color
    • utrecht.form-toggle.disabled.border-style
    • utrecht.form-toggle.disabled.border-width
    • utrecht.form-toggle.disabled.color
    • utrecht.form-toggle.hover.background-color
    • utrecht.form-toggle.hover.color
    • utrecht.form-toggle.focus.border-color
    • utrecht.form-toggle.focus.border-style
    • utrecht.form-toggle.focus.border-width
    • utrecht.form-toggle.thumb.background-color
    • utrecht.form-toggle.thumb.border-radius
    • utrecht.form-toggle.thumb.box-shadow
    • utrecht.form-toggle.thumb.margin-inline-end
    • utrecht.form-toggle.thumb.margin-inline-start
    • utrecht.form-toggle.thumb.min-inline-size
    • utrecht.form-toggle.thumb.disabled.background-color
    • utrecht.form-toggle.thumb.disabled.box-shadow
    • utrecht.form-toggle.track.border-color
    • utrecht.form-toggle.track.border-radius
    • utrecht.form-toggle.track.disabled.background-color

... (truncated)

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Apr 2, 2026
@dependabot dependabot Bot requested a review from a team as a code owner April 2, 2026 04:05
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Apr 2, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clippy-storybook Ready Ready Preview Apr 9, 2026 6:41pm
theme-wizard Ready Ready Preview Apr 9, 2026 6:41pm
theme-wizard-server Ready Ready Preview Apr 9, 2026 6:41pm

Request Review

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
theme-wizard Building Building Preview Apr 2, 2026 4:05am

Request Review

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/nl-design-system-unstable/start-design-tokens-5.1.0 branch from ea19f21 to a4366a1 Compare April 3, 2026 13:44
@bartveneman
Copy link
Copy Markdown
Contributor

This PR is blocked because of a known contrast issue that we need a solution for (ignore or fix):

AssertionError: [
  {
    "actual": 1.9744079739080689,
    "code": "too_small",
    "ERROR_CODE": "insufficient_contrast",
    "message": "Insufficient contrast",
    "minimum": 4.5,
    "origin": "number",
    "path": [
      "utrecht",
      "form-toggle",
      "hover",
      "color",
      "$value"
    ],
    "tokens": [
      "utrecht.form-toggle.hover.color",
      "utrecht.form-toggle.hover.background-color"
    ]
  },
  {
    "actual": 1.9744079739080689,
    "code": "too_small",
    "ERROR_CODE": "insufficient_contrast",
    "message": "Insufficient contrast",
    "minimum": 4.5,
    "origin": "number",
    "path": [
      "utrecht",
      "form-toggle",
      "hover",
      "background-color",
      "$value"
    ],
    "tokens": [
      "utrecht.form-toggle.hover.background-color",
      "utrecht.form-toggle.hover.color"
    ]
  }

Bumps [@nl-design-system-unstable/start-design-tokens](https://github.com/nl-design-system/themes/tree/HEAD/packages/start-design-tokens) from 2.4.1 to 5.1.0.
- [Release notes](https://github.com/nl-design-system/themes/releases)
- [Changelog](https://github.com/nl-design-system/themes/blob/main/packages/start-design-tokens/CHANGELOG.md)
- [Commits](https://github.com/nl-design-system/themes/commits/@nl-design-system-unstable/voorbeeld-design-tokens@5.1.0/packages/start-design-tokens)

---
updated-dependencies:
- dependency-name: "@nl-design-system-unstable/start-design-tokens"
  dependency-version: 5.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/nl-design-system-unstable/start-design-tokens-5.1.0 branch from a4366a1 to f7689f7 Compare April 9, 2026 14:04
@bartveneman
Copy link
Copy Markdown
Contributor

bartveneman commented Apr 9, 2026

Relevant thread in Slack channel: https://codefornl.slack.com/archives/C01D78C2E4E/p1775739878038599

Screenshot 2026-04-09 at 16 29 51

TL;DR: the component that this contrast issue applies to shows no text whatever the circumstances, so in this case it seems a false positive. I'm going to opt for an allowList or ignoreList for color/bg combos of component contrast tokens.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2026

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.50%. Comparing base (573f4a2) to head (0efcecd).
⚠️ Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   88.06%   84.50%   -3.56%     
==========================================
  Files          57       71      +14     
  Lines        1701     2169     +468     
  Branches      378      494     +116     
==========================================
+ Hits         1498     1833     +335     
- Misses        166      279     +113     
- Partials       37       57      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bartveneman bartveneman merged commit e738366 into main Apr 9, 2026
10 checks passed
@bartveneman bartveneman deleted the dependabot/npm_and_yarn/nl-design-system-unstable/start-design-tokens-5.1.0 branch April 9, 2026 18:42
@github-project-automation github-project-automation Bot moved this from Waiting for others to Done in Expertteam Digitale Toegankelijkheid 2025 Apr 9, 2026
bartveneman added a commit that referenced this pull request Apr 10, 2026
- all major updates for `@amsterdam` packages
- remove unused dependency from theme-wizard-app
- fix: upgrading start tokens in #667 broke the custom property mapping
of clippy-modal because the `todo.modal-dialog.*` tokens were [removed
in
v3.0.0](https://github.com/nl-design-system/themes/blob/main/packages/start-design-tokens/CHANGELOG.md#300).
Removing this broken mapping fixes the issue.

<img width="778" height="314" alt="Screenshot 2026-04-09 at 21 41 09"
src="https://github.com/user-attachments/assets/7cd7fbc9-cbe1-4387-acf0-2f45ebbf9a2d"
/>

- [x] I did visual regression more thoroughly this time

---------

Co-authored-by: Bram Smulders <source@bram.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

Development

Successfully merging this pull request may close these issues.

2 participants