Optimize translation module, integrate franc for language detection.#7
Open
sajidurdev wants to merge 1 commit intonishantapps:mainfrom
Open
Optimize translation module, integrate franc for language detection.#7sajidurdev wants to merge 1 commit intonishantapps:mainfrom
sajidurdev wants to merge 1 commit intonishantapps:mainfrom
Conversation
Code optimization encompassed modularization, having unique functions for translation and API queries, frequent usage of ‘async/await’ for improved readability, and thorough exception handling. By switching from ’langdetect’ to franc, language detection became smoother and more accurate. These adjustments are made to make this translation module more practical and sustainable.
Contributor
npmnishantsharma
left a comment
There was a problem hiding this comment.
- Franc is an ejs module for which you have to configure it
- Language code of franc are different from translate-google
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
1. Language Detection Module:
2. Refactored Language Detection Logic:
franc (promptfor enhanced precision.3. Variable Renaming:
detectedLangCodeintodetectedLangto follow consistency and clarity.4. Error Handling Improvement:
franc.5. Removed Translate Call for Prompt:
6. Consistent Async/Await:
async/awaitwas applied uniformly for the asynchronous operations in the entire code.7. Modularized Code:
translateText, andmakeApiRequest) for greater modularity.8. Error Handling for API Requests:
9. Improved Comments:
10. Function Renaming:
resvariable totranslatedPromptfor ease of understanding.