Skip to content

socketId added, on_connection_state_change , when pusher connected.#12

Open
usmanokara wants to merge 2 commits intoninjasolutions:masterfrom
usmanokara:master
Open

socketId added, on_connection_state_change , when pusher connected.#12
usmanokara wants to merge 2 commits intoninjasolutions:masterfrom
usmanokara:master

Conversation

@usmanokara
Copy link
Copy Markdown

@usmanokara usmanokara commented Mar 20, 2021

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature

⤵️ What is the current behavior?

User can listen to connection status (previous and new)

🆕 What is the new behavior (if this is a feature change)?

Now user can access socket Id when connected to Pusher. This socket id is required for private and presence channel subscription.

💥 Does this PR introduce a breaking change?

Yeah. before this user cannot subscribe to PresenceChannel. because Authentication is required. But Authentication needs socket Id. So now socket Id is available.

🐛 Recommendations for testing

User can print socket Idwhen pusher status is connected and can verify from Pusher console log.

📝 Links to relevant issues/docs

#7
#6

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@usmanokara
Copy link
Copy Markdown
Author

hi @josh-burton please review my pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant