Skip to content

add prop onEditorState#8

Open
milahu wants to merge 1 commit into
nimeshnayaju:mainfrom
milahu:patch-2
Open

add prop onEditorState#8
milahu wants to merge 1 commit into
nimeshnayaju:mainfrom
milahu:patch-2

Conversation

@milahu
Copy link
Copy Markdown

@milahu milahu commented Sep 20, 2022

replace #7

editorState is useful to get the new parse tree in editorState.tree.topNode

todo: add type

todo: rename to onEditorStateChanged, because this is not called for the initial state

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 20, 2022

⚠️ No Changeset found

Latest commit: 6e6e669

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solid-codemirror ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 8:52AM (UTC)

@nimeshnayaju
Copy link
Copy Markdown
Owner

Hey, thanks for making this PR. I like the idea of adding a onEditorStateChange prop. I also like the optimization change you made in #7! Feel free to reach out if you need help with anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants